Add math function that return the enchantment value #81691
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
added
<Documentation>
GuardianDll
force-pushed
the
math_enchantment_reading
branch
from
c4fac82 to
1a679b3
Compare
|
You probably want to use string_to_enum_look_up_optional and check the return value, debugmsg with callstack if it's std::nullopt. string_to_enum will throw if the provided value is not an actual enum, which is bad (crashing!) and difficult to diagnose. |
GuardianDll
force-pushed
the
math_enchantment_reading
branch
from
1a679b3 to
b71037b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Json power
Describe the solution
Add a code that exposes character enchantment to math
Testing