Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

canteen 2 roofed #73870

Merged
merged 1 commit into from
May 17, 2024
Merged

canteen 2 roofed #73870

merged 1 commit into from
May 17, 2024

Conversation

PatrikLundell
Copy link
Contributor

Summary

None

Purpose of change

Make canteen expansion 2 roofs explicit (plus some smoke venting furniture on the roof).

Describe the solution

Make use of the 3D coordinate capabilities to extend the mapgen definitions for the canteen.

Describe alternatives you've considered

Testing

  • Loaded a save and created a canteen 2 expansion.
  • Constructed the building in 7 materials, plus fireplaces, the smoking racks, and the still.
  • Verified the building looked correct both at the ground level and from the roof.
  • Quit and redid the first step.
  • Created the first canteen section using the last material.
  • Constructed stoves instead of fireplaces in it.
  • Looked at the ground level as well as the roof to verify things look correct.

Screenshot (358)
Screenshot (359)
Screenshot (360)
Screenshot (361)

Additional context

I've noted for a while that characters suffer from map amnesia, i.e. they no longer remember furniture (which gets extra silly with tents).

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display Crafting / Construction / Recipes Includes: Uncrafting / Disassembling astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels May 17, 2024
@Maleclypse Maleclypse merged commit 8ef41bc into CleverRaven:master May 17, 2024
20 of 26 checks passed
@PatrikLundell PatrikLundell deleted the canteen2 branch May 17, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Crafting / Construction / Recipes Includes: Uncrafting / Disassembling [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants