Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add night vision helmet attachments #73869

Merged
merged 13 commits into from
May 26, 2024

Conversation

b0bhat
Copy link
Contributor

@b0bhat b0bhat commented May 17, 2024

Summary

Content "Night vision helmet attachments"

Purpose of change

New NVGs which can be attached to military helmets via a pocket and can be quickly deactivated and swung out of the way to avoid obstructing eyes.
#70533

Describe the solution

Adds three new helmet NVG attachments, attaching on military helmets, mutually exclusive with face shields.
An older NVG, modern GPNVG, and a fancy enhanced/fusion NVG (light amplification + thermal).
These nvgs are a bit better and more efficient than the existing light amp goggles but need to be mounted on the army helmet, tactical helmet, or airsoft helmet. I tried to follow online stats for these goggles while keeping them in line with other gear.

Night vision goggles also use the low light overlay instead of the green overlay due to the NIGHT_VIS enchantment.

Old light amp goggles are reworked to clarify they are civilian active night vision goggles (IR camera + IR flashlight), which are comparatively more available, less expensive, and draw more power. Distribution has also been changed.

The ENVG is currently only issued to a few US army units right now so it'll probably be the rarest to find.

Describe alternatives you've considered

re-add in green overlay?
Also add a craftable headband thingy which can be worn with other hats to mount NVGs
Allow crafting the old light amp goggles
Remove light amp goggles entirely
Instead of the helmet inheriting the nvg flag, change character nv detection to check in certain pockets for nv

Testing

Spawned soldier zombies and tested spawning
looked around
tested powered and unpowering conditions
Tested morale with filthy helmets

Additional context

@b0bhat b0bhat marked this pull request as draft May 17, 2024 07:51
@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display Spawn Creatures, items, vehicles, locations appearing on map Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies [C++] Changes (can be) made in C++. Previously named `Code` Items: Armor / Clothing Armor and clothing labels May 17, 2024
src/cata_tiles.cpp Outdated Show resolved Hide resolved
src/character.cpp Outdated Show resolved Hide resolved
src/character.cpp Outdated Show resolved Hide resolved
src/character.cpp Outdated Show resolved Hide resolved
src/character.cpp Outdated Show resolved Hide resolved
src/pixel_minimap.cpp Outdated Show resolved Hide resolved
@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label May 17, 2024
@GuardianDll
Copy link
Member

why use hardcoded vision mod instead of something like NIGHT_VIS enchantment?

@b0bhat
Copy link
Contributor Author

b0bhat commented May 17, 2024

why use hardcoded vision mod instead of something like NIGHT_VIS enchantment?

Oh thanks for letting me know, I'll look into that! That might also fix one of the issues I've been having too

@Hyperseeker
Copy link
Contributor

Hyperseeker commented May 17, 2024

For what it's worth, the GPNVG (presumably that from L3Harris, since the weight matches) goes for around $47k: source 1, source 2.

Also, for what it's worth, it seems to be powered by a battery pack that straps at the back of the helmet. I believe a better implementation of that in the game would be making the GPNVG feed from UPS, and maybe adding a small helmet-mounted UPS pack. AA batteries (which is what the light battery is supposed to be) really don't do an NVG justice.

EDIT: Initially I also wanted to mention the dimensions and the volume of the thing, given that sources list what amounts to almost 3 L of raw volume (and something like 2.4 L when accounting for the nooks and crannies), but that just doesn't seem right.

@b0bhat
Copy link
Contributor Author

b0bhat commented May 18, 2024

@Hyperseeker thanks for your feedback, will adjust the stats. It's a bit hard to figure out the volumes since they can fold, though I did bump them up.

The helmet UPS idea is an cool idea, maybe it could also be used alongside helmet flashlights, but I don't know how to prevent the helmet UPS from powering a character's ups tools too. I'm guessing it would also take light batteries.

The GPNVG requires a battery pack, some other NVGs have internal battery packs, taking CR123A or AA, and the battery pack linked takes 4 AA batteries.
What do you think about adding a head back coverage portion to the GPNVG to represent the battery pack and cutting battery longevity by ~4 or so, while keeping the light battery internal?

@Hyperseeker
Copy link
Contributor

The thing about volume is that it remains the same regardless of the item's position or shape. Even when folded, they would take up exactly as much space, even if their 3-dimensional bounding box would look very-different. Like I mentioned, though, I think the 3 L volume from available dimensions is nonsense: one of the promo images puts the NVG (attached to a helmet) next to (what looked like) an MP7, and the NVG wasn't quite as big as the SMG.

but I don't know how to prevent the helmet UPS from powering a character's ups tools too

This may not be relevant. The UPS is a nebulous technology that connects to any number of devices simultaneously using no cables. We can contemplate all the possible ways to make it more-realistic (like only allowing this UPS model to power that device, because proprietary connectors are a thing), but as long as the game itself isn't bothering with it, I reckon neither should you. Make it a low-capacity UPS that takes light or medium batteries (as opposed to the original UPS' heavy batteries), and let it be used in whatever ways the game allows.

Maybe one day someone will make the UPS something meaningful, like a USB power bank that needs a cable to connect and can only take up to X connections. Maybe that would also pave way to in-game proprietary power connectors and such. Until then, I figure we play the hand we've been dealt.

What do you think about adding a head back coverage portion to the GPNVG to represent the battery pack and cutting battery longevity by ~4 or so, while keeping the light battery internal?

That's viable. You will also need to bump up the GPNVG's volume to represent the battery pack.

Though if you're going with batteries, you probably should go with medium ones for the device, and ditch the battery pack altogether. The medium battery would be enough to "fill out" the NVG in terms of volume and power supply. When attached, the battery would add volume to the whole arrangement, effectively acting as "that thing that hangs off the back of your helmet".

In fact, now that I think about it, this is probably the best solution. It adds viable content without requiring additional infrastructure (e.g., a custom UPS) that you'd have to make fit into the world as a developer. (And if you do like the idea of a custom UPS enough to add it into the game, you can always add it later, and keep the changes manageable within the scope of their respective PR.)

@github-actions github-actions bot added the Mechanics: Enchantments / Spells Enchantments and spells label May 18, 2024
Copy link
Contributor

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • Advanced GPNVG with four image intensifier tubes, allowing for a large field of view at night. Is designed to be mounted to a helmet. Currently raised up and out of the way.
  • Advanced GPNVG with four image intensifier tubes, allowing for a large field of view at night. Is designed to be mounted to a helmet. It is turned on, and continually draining batteries. Use it to turn them off.
  • New and rare high-resolution thermal NVG device, designed to be mounted to a helmet. Lets you see in the dark, and detects heat signatures emitted by (un)living organisms. Currently raised up and out of the way.
  • New and rare high-resolution thermal NVG device, designed to be mounted to a helmet. Lets you see in the dark, and detects heat signatures emitted by (un)living organisms. It is turned on, and continually draining batteries. Use it to turn them off.
  • You are wearing NVGs which allow you to poorly see in the dark.
  • You are wearing NVGs which allow you to see in the dark.
  • You are wearing NVGs which allow you to see quite well in the dark.

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

Hints for adding a new word to the dictionary
  • If the word is normally in all lowercase, such as the noun word or the verb does, add it in its lower-case form; if the word is a proper noun, such as the surname George, add it in its initial-caps form; if the word is an acronym or has special letter case, such as the acronym CDDA or the unit mW, add it by preserving the case of all the letters. A word in the dictionary will also match its initial-caps form (if the word is in all lowercase) and all-uppercase form, so a word should be added to the dictionary in its normal letter case even if used in a different letter case in a sentence.
  • For a word to be added to the dictionary, it should either be a real, properly-spelled modern American English word, a foreign loan word (including romanized foreign names), or a foreign or made-up word that is used consistently and commonly enough in the game. Intentional misspelling (including eye dialect) of a word should not be added unless it has become a common terminology in the game, because while someone may have a legitimate use for it, another person may spell it that way accidentally.

@github-actions github-actions bot added the astyled astyled PR, label is assigned by github actions label May 18, 2024
@b0bhat b0bhat changed the title [WIP] Add night vision helmet attachments Add night vision helmet attachments May 19, 2024
@b0bhat b0bhat marked this pull request as ready for review May 19, 2024 19:09
@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions and removed astyled astyled PR, label is assigned by github actions labels May 20, 2024
@marilynias
Copy link
Contributor

not sure how you handle stale issues, but also closes my old issue #62601

@Maleclypse Maleclypse merged commit 903ade8 into CleverRaven:master May 26, 2024
20 of 26 checks passed
@Meadevil
Copy link

Meadevil commented May 31, 2024

example in the mines using tiles

Screenshot_20240601_145621
Screenshot_20240601_145857

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` Items: Armor / Clothing Armor and clothing [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display Mechanics: Enchantments / Spells Enchantments and spells Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies Spawn Creatures, items, vehicles, locations appearing on map
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants