Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ski mask a tube scarf #73855

Closed
wants to merge 4 commits into from
Closed

Ski mask a tube scarf #73855

wants to merge 4 commits into from

Conversation

Kamejeir
Copy link
Contributor

Summary

None

Purpose of change

The ski mask was not sufficiently sublimbed when I wanted to use it. The end result of my thoughts (and the help of Karol giving input, a Discord link) made it make the most sense as being remodeled into a tube scarf.

Describe the solution

The ski mask in its original form is largely unchanged, made to work with a gas mask to avoid a regression. The warmth value on that form was changed to work more nicely with how the "open" form, now using sublimbs, reduce that warmth via using less total sublimb coverage.

The "open" form pretends to be worn around the neck, allowing dragging it over your mouth when wanting to avoid being struck with a chilling gust of wind while skiing downhill, for example. I thought that made sense, with that being the way I use mine.

Describe alternatives you've considered

Testing

This coming out of draft will imply having tested that the warmth value is applied properly with changing forms, as well as getting any weird json stuff out of the way and whatnot.

Additional context

I should go wear the thing over my head to see how much I can cover. I'll include that when going out of draft.

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Items: Armor / Clothing Armor and clothing new contributor labels May 16, 2024
@github-actions github-actions bot added the astyled astyled PR, label is assigned by github actions label May 16, 2024
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels May 18, 2024
@Kamejeir Kamejeir closed this by deleting the head repository May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Items: Armor / Clothing Armor and clothing [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants