Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dhcp: migrate leases to be scope scoped instead of global #1304

Open
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

BeryJu
Copy link
Owner

@BeryJu BeryJu commented Nov 20, 2024

closes #1269

Copy link

netlify bot commented Nov 20, 2024

Deploy Preview for beryju-gravity canceled.

Name Link
🔨 Latest commit 412313a
🔍 Latest deploy log https://app.netlify.com/sites/beryju-gravity/deploys/6743ebe6f7f435000822deb2

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 48.11321% with 165 lines in your changes missing coverage. Please review.

Project coverage is 60.36%. Comparing base (0a66b6d) to head (412313a).

❌ We are unable to process any of the uploaded JUnit XML files. Please ensure your files are in the right format.

Files with missing lines Patch % Lines
pkg/roles/dhcp/role_migrations.go 0.00% 92 Missing ⚠️
pkg/roles/dhcp/api_leases.go 16.66% 34 Missing and 1 partial ⚠️
pkg/roles/dhcp/scopes.go 72.41% 12 Missing and 4 partials ⚠️
pkg/roles/dhcp/scopes_watch.go 53.33% 5 Missing and 2 partials ⚠️
pkg/roles/dhcp/scope_selector.go 86.48% 4 Missing and 1 partial ⚠️
pkg/extconfig/log.go 0.00% 2 Missing and 1 partial ⚠️
pkg/instance/api_instance.go 83.33% 2 Missing and 1 partial ⚠️
pkg/roles/dhcp/api_scopes.go 81.25% 2 Missing and 1 partial ⚠️
cmd/cli/cli_health.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1304      +/-   ##
==========================================
- Coverage   61.15%   60.36%   -0.80%     
==========================================
  Files         108      109       +1     
  Lines        6125     6221      +96     
==========================================
+ Hits         3746     3755       +9     
- Misses       2030     2116      +86     
- Partials      349      350       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BeryJu BeryJu force-pushed the dhcp/migrate-leases-woooo branch 2 times, most recently from ce88df3 to 5fcc401 Compare November 22, 2024 00:18
@BeryJu BeryJu force-pushed the dhcp/migrate-leases-woooo branch from 5fcc401 to 57e6190 Compare November 24, 2024 16:09
@BeryJu BeryJu force-pushed the dhcp/migrate-leases-woooo branch from 57e6190 to 0d8a5b3 Compare November 24, 2024 23:59
Copy link

codecov bot commented Nov 25, 2024

Bundle Report

Changes will increase total bundle size by 1.67kB (0.05%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gravity-ui-esm 3.53MB 1.67kB (0.05%) ⬆️

@BeryJu BeryJu force-pushed the dhcp/migrate-leases-woooo branch from 0d8a5b3 to 7f5cc48 Compare November 25, 2024 00:24
@BeryJu BeryJu force-pushed the dhcp/migrate-leases-woooo branch from 9702a75 to 99334a6 Compare November 25, 2024 01:46
@BeryJu BeryJu force-pushed the dhcp/migrate-leases-woooo branch from 9043338 to 17f6cdb Compare November 25, 2024 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DHCP changed request scope
1 participant