Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dhcp: fix scope moving when it shouldn't #1270

Closed
wants to merge 3 commits into from
Closed

Conversation

BeryJu
Copy link
Owner

@BeryJu BeryJu commented Nov 2, 2024

closes #1269

Copy link

netlify bot commented Nov 2, 2024

Deploy Preview for beryju-gravity canceled.

Name Link
🔨 Latest commit cd84a2c
🔍 Latest deploy log https://app.netlify.com/sites/beryju-gravity/deploys/672a79d2b0b7bd0008fa5324

Copy link

codecov bot commented Nov 2, 2024

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
1 1 0 0
View the top 1 failed tests by shortest run time
beryju.io/gravity/pkg/roles/dhcp TestDHCPRequestDNS_ChangedScope
Stack Traces | 0.11s run time
Failed

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

@BeryJu BeryJu force-pushed the dhcp/fix-scope-moving branch from f842068 to fced74a Compare November 5, 2024 14:22
@BeryJu BeryJu force-pushed the dhcp/fix-scope-moving branch from fced74a to cd84a2c Compare November 5, 2024 20:02
@BeryJu
Copy link
Owner Author

BeryJu commented Nov 23, 2024

superseded by #1304

@BeryJu BeryJu closed this Nov 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DHCP changed request scope
1 participant