ardupilotmega: use params 6 and 7 of MAV_CMD_DO_START_MAG_CAL to pass lon/lat #238
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tridge
requested changes
Jan 17, 2022
| @@ -158,8 +158,8 @@ | |||
| <param index="3" label="Autosave" minValue="0" maxValue="1" increment="1">Save without user input (0=require input, 1=autosave).</param> | |||
| <param index="4" label="Delay" units="s">Delay.</param> | |||
| <param index="5" label="Autoreboot" minValue="0" maxValue="1" increment="1">Autoreboot (0=user reboot, 1=autoreboot).</param> | |||
| <param index="6">Empty.</param> | |||
| <param index="7">Empty.</param> | |||
| <param index="6" label="Latitude" units="deg">Latitude where calibration is happening, for vehicles with no GPS.</param> | |||
There was a problem hiding this comment.
needs the comment to say that zero means to ignore
… lon/lat This will improve the calibration of compasses on vehicles not equipped with a GPS. As `fix_radius()` in step two of calibration requires a GPS lock.
Williangalvani
force-pushed
the
magcal_lonlat
branch
from
0b15877
to
65557bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will improve the calibration of compasses on vehicles not equipped with a GPS, As
fix_radius()in step two of calibration requires a GPS lock.