-
Notifications
You must be signed in to change notification settings - Fork 407
SUNDIALS interface updates #4562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
gardner48
wants to merge
22
commits into
AMReX-Codes:development
Choose a base branch
from
gardner48:sundials-interface-fixes
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
c62b3c9
fix setting imex methods
gardner48 38d90b1
fix fast method checks
gardner48 817be37
update output
gardner48 7703fb4
read base integrator parameters
gardner48 d743e9b
update config output
gardner48 08086bc
fix typos
gardner48 a96668a
add asserts
gardner48 b53f8f1
abort if the RHS function is empty
gardner48 37d0a3a
print integrator stats on destruction
gardner48 baf178b
add fixed point option
gardner48 5ceefe3
options to set max nonlinear and linear iterations
gardner48 a359684
add stop time option
gardner48 7767277
option to set max steps
gardner48 0a9be5b
wrap output in if verbose
gardner48 f7bb5c9
fix typos
gardner48 2888172
add options to set different fast and slow solvers
gardner48 5ca3ebf
use fast version of solver objects
gardner48 6837986
fix setting fast_time_step
gardner48 adddd0a
update comment
gardner48 f2e149d
document runtime parameters
gardner48 e8333f3
add links to runtime inputs
gardner48 8081a67
fix typo
gardner48 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could the prefix used be
time_integration
rather thanintegration
? this would be more consistent with the object and folder naming. If this would require invasive changes elsewhere it's not required