-
Notifications
You must be signed in to change notification settings - Fork 407
SUNDIALS interface updates #4562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: development
Are you sure you want to change the base?
SUNDIALS interface updates #4562
Conversation
FYI @ajnonaka, various updates I made when testing with FerroX. I'll open a PR with some corresponding updates on the FerroX side as well. |
@@ -17,8 +17,8 @@ to :cpp:`amrex::Initialize` and the function adds parameters to AMReX's | |||
.. important:: AMReX reserves the following prefixes in :cpp:`ParmParse` | |||
parameters: ``amr``, ``amrex``, ``blprofiler``, ``device``, | |||
``DistributionMapping``, ``eb2``, ``fab``, ``fabarray``, | |||
``geometry``, ``particles``, ``tiny_profiler``, and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could the prefix used be time_integration
rather than integration
? this would be more consistent with the object and folder naming. If this would require invasive changes elsewhere it's not required
Summary
Additional background
Various fixes and enhancements from testing methods in FerroX
Checklist
The proposed changes: