Make sure `pip install` builds js assets #21

yuvipanda · 2024-03-28T03:16:30Z

Also deletes MANIFEST.in, so setuptools-scm include everything in the git repo in the built package,
which then allows build to find the package.json and other
files to build. I guess a 'source' distribution should include
the JS and CSS files. This increases file size by a few kb but that's
fine.

Ref #20

1. `pip install -e .` is needed, and will also do the initial JS / CSS build from #21 2. Add a note about `npm run webpack:watch` to rebuild changes 3. Use `python -m jupyterhub` to run jupyterhub, to minimize chances of venv shennanigans Fixes #20

This includes everything in the git repo in the built package, which then allows `build` to find the `package.json` and other files to build. I guess a 'source' distribution *should* include the JS and CSS files. This increases file size by a few kb but that's fine.

Make sure pip install builds js assets

07b1861

Ref #20

yuvipanda mentioned this pull request Mar 28, 2024

Add additional steps to CONTRIBUTING.md #22

Merged

yuvipanda merged commit f4f869d into main Mar 28, 2024
3 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make sure `pip install` builds js assets #21

Make sure `pip install` builds js assets #21

yuvipanda commented Mar 28, 2024 •

edited

Loading

Make sure pip install builds js assets #21

Make sure pip install builds js assets #21

Conversation

yuvipanda commented Mar 28, 2024 • edited Loading

Make sure `pip install` builds js assets #21

Make sure `pip install` builds js assets #21

yuvipanda commented Mar 28, 2024 •

edited

Loading