Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add additional steps to CONTRIBUTING.md #22

Merged
merged 1 commit into from
Mar 28, 2024
Merged

Add additional steps to CONTRIBUTING.md #22

merged 1 commit into from
Mar 28, 2024

Conversation

yuvipanda
Copy link
Member

  1. pip install -e . is needed, and will also do the initial JS / CSS build from Make sure pip install builds js assets #21
  2. Add a note about npm run webpack:watch to rebuild changes
  3. Use python -m jupyterhub to run jupyterhub, to minimize chances of venv shennanigans

Fixes #20

@yuvipanda
Add additional steps to CONTRIBUTING.md
4b506d6 
1. `pip install -e .` is needed, and will also do the initial
   JS / CSS build from #21
2. Add a note about `npm run webpack:watch` to rebuild changes
3. Use `python -m jupyterhub` to run jupyterhub, to minimize
   chances of venv shennanigans

Fixes #20
@yuvipanda yuvipanda merged commit 1afb6f3 into main Mar 28, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing pip install -e . step in CONTRIBUTING.md
1 participant
@yuvipanda