Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

basehub: reduce hub.loadRoles and clarify the situation #4030

Merged
merged 3 commits into from
May 8, 2024
Merged

basehub: reduce hub.loadRoles and clarify the situation #4030

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3791980
basehub: reduce hub.loadRoles and clarify the situation
consideRatio May 7, 2024
7327486
basehub: remove configurator / dask-gateway notes on loadRoles
consideRatio May 8, 2024
7c717b1
basehub: remove hub.loadRoles entirely
consideRatio May 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions helm-charts/basehub/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -597,15 +597,6 @@ jupyterhub:
matchLabels:
app.kubernetes.io/component: traefik
hub:
loadRoles:
# Should use this, not hub.config.JupyterHub.load_roles - that will
# override any existing load_roles set by z2jh
service-use:
name: user
scopes:
# Allow all users access to 'services', which includes dask-gateway & configurator
- access:services
- self
config:
JupyterHub:
# Allow unauthenticated prometheus requests
Expand Down