basehub: reduce hub.loadRoles and clarify the situation #4030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as duplicate.
This comment was marked as duplicate.
yuvipanda
requested changes
May 7, 2024
helm-charts/basehub/values.yaml
Outdated
| # Allow all users access to 'services', which includes dask-gateway & configurator | ||
| - access:services | ||
| - self | ||
| # hub.loadRoles is z2jh native config to enable configuration of |
There was a problem hiding this comment.
yay that it has no effect and we can remove it.
I'd suggest we just simply fully remove it, and not actually have this large comment here. It adds additional things that must be kept up to date whenever things elsewhere change, and makes this already large file even larger. Let's just remove that?
yuvipanda
reviewed
May 7, 2024
helm-charts/basehub/values.yaml
Outdated
| # Considerations of updating dask-gateway to gate access via | ||
| # access:services!service=dask-gateway is considered in the linked issue. | ||
| # | ||
| # ref: https://github.com/dask/dask-gateway/issues/829 |
There was a problem hiding this comment.
#4014 is the right place for this and i see you've already put it there!
|
Thank you for reviewing @yuvipanda! I've tested as non-admin on imagebuilding-demo as well which worked ok
Merging! |
|
🎉🎉🎉🎉 Monitor the deployment of the hubs here 👉 https://github.com/2i2c-org/infrastructure/actions/runs/8997821392 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had configuration under
hub.loadRolesthat didn't make a difference. With this PR I'm removing it and adding related comments about it for the future instead.