Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support chart, grafana: allow memory to peak to 2x requests and disable readinessProbe #3868

Merged
merged 2 commits into from
Apr 3, 2024
Merged

support chart, grafana: allow memory to peak to 2x requests and disable readinessProbe #3868

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6b5bec7
support chart, grafana: allow memory to peak to 2x requests
consideRatio Mar 27, 2024
3fe8547
support chart, grafana: tweak readinessProbe for our single replica
consideRatio Mar 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions helm-charts/support/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,6 +281,12 @@ grafana:
# type Recreate is required since we attach a PVC that can only be used by
# mounted for writing by one pod at the time.
type: Recreate
readinessProbe:
# With one grafana pod replica, having a readiness probe fail is pointless.
# We ensure it won't fail before the livenessProbe that would restart the
# container.
failureThreshold: 1000
initialDelaySeconds: 1

rbac:
# namespaced makes us not get ClusterRole service accounts etc, and we do
Expand All @@ -297,8 +303,10 @@ grafana:
# prometheus and grafana.
#
# Grafana's memory use seems to increase over time but seems reasonable to
# stay below 200Mi for years to come. Grafana's CPU use seems minuscule with
# peaks at up to 9m CPU from one user is browsing its dashboards.
# stay below 200Mi in general. Memory can peak when dashboards are updated,
# and was increased to 400Mi as its been seen getting OOMKilled. Grafana's CPU
# use seems minuscule with peaks at up to 9m CPU from one user is browsing its
# dashboards.
#
# PromQL queries for CPU and memory use:
# - CPU: sum(rate(container_cpu_usage_seconds_total{container="grafana", namespace="support"}[5m])) by (pod)
Expand All @@ -307,7 +315,7 @@ grafana:
resources:
limits:
cpu: 100m
memory: 200Mi
memory: 400Mi
requests:
cpu: 10m
memory: 200Mi
Expand Down