support chart, grafana: allow memory to peak to 2x requests and disable readinessProbe #3868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
consideRatio
changed the title
This comment was marked as resolved.
This comment was marked as resolved.
consideRatio
force-pushed
the
pr/tweak-grafana
branch
from
36bf89d to
f7ed7c8
Compare
consideRatio
force-pushed
the
pr/tweak-grafana
branch
from
f7ed7c8 to
3fe8547
Compare
|
🎉🎉🎉🎉 Monitor the deployment of the hubs here 👉 https://github.com/2i2c-org/infrastructure/actions/runs/8534873121 |
|
I went for a merge to flush this from being a ball in the air nudging my attention - I feel very confident about this change technically |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was used to fix deploy grafana dashboards failures observed in pangeo-hubs which has a heavy load on prometheus/grafana due to use of many dask worker nodes collecting substantial amounts of metrics.
Grafana has been OOMKilled in pangeo-hubs at least, and this resolved it. Since grafana sometimes need temporary additional memory rather than consistently need more memory, I think its reasonable to increase the limit without increasing the request.