Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

envNext #128

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

envNext #128

wants to merge 13 commits into from

Conversation

friedolino78
Copy link
Contributor

@friedolino78 friedolino78 commented Jun 3, 2021 •
edited

@friedolino78 friedolino78 marked this pull request as draft June 3, 2021 21:47
@JohannesLorenz
Copy link
Contributor

Rename this from "En vnext" to "Env next"?

@friedolino78 friedolino78 changed the title En vnext envNext Jun 6, 2021
@friedolino78 friedolino78 marked this pull request as ready for review February 6, 2022 19:00
fundamental
fundamental reviewed Feb 28, 2022
View reviewed changes
src/Synth/Envelope.cpp Outdated Show resolved Hide resolved
fundamental
fundamental reviewed Feb 28, 2022
View reviewed changes
src/Synth/Envelope.cpp Outdated Show resolved Hide resolved
@fundamental
Copy link
Member

As per the GUI comments, I'm not convinced that the currently proposed bezier behavior should be the final one.

@friedolino78
Copy link
Contributor Author

As per the GUI comments, I'm not convinced that the currently proposed bezier behavior should be the final one.

i changed it to 2nd order beziers with 2 control points per segment.

JohannesLorenz
JohannesLorenz reviewed Jul 23, 2023
View reviewed changes
Copy link
Contributor

@JohannesLorenz JohannesLorenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now, I gave only a few comments in order to clean up the PR a bit.

src/Params/EnvelopeParams.cpp Outdated Show resolved Hide resolved
src/Params/EnvelopeParams.cpp Outdated Show resolved Hide resolved
src/Params/EnvelopeParams.cpp Outdated Show resolved Hide resolved
src/Params/EnvelopeParams.cpp Outdated Show resolved Hide resolved
src/Params/EnvelopeParams.cpp Outdated Show resolved Hide resolved
src/Params/EnvelopeParams.cpp Outdated Show resolved Hide resolved
src/Params/EnvelopeParams.cpp Outdated Show resolved Hide resolved
src/Params/EnvelopeParams.cpp Outdated Show resolved Hide resolved
src/Params/EnvelopeParams.cpp Outdated Show resolved Hide resolved
src/Params/EnvelopeParams.cpp Outdated Show resolved Hide resolved
@JohannesLorenz
Copy link
Contributor

@friedolino78 Let me know when you have addressed all the review comments. At least some seem not to be solved yet, so i will just wait for now.

@friedolino78 friedolino78 mentioned this pull request Nov 16, 2023
Open
@friedolino78
Copy link
Contributor Author

@friedolino78 Let me know when you have addressed all the review comments. At least some seem not to be solved yet, so i will just wait for now.

I guess your comments are all solved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fundamental fundamental fundamental left review comments

@JohannesLorenz JohannesLorenz JohannesLorenz left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@friedolino78 @JohannesLorenz @fundamental