Fix some bugs #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey. This looks pretty abandoned, but in case it isn't, I made a few fixes.
When building on newer versions of VS using Windows 10, I ran into to issues that required including a few more headers.
The DXBC binaries I was looking at would sometimes use uppercase
CBwhen declaring constant buffers. I made the code that parses these case insensitive.mCBufferNamesis never empty since an entry is added explicitly inParseBufferDefinitions. I changed a check that relies on it being empty to account for this. This lets the binaries I was reversing successfully decompile, since the explicit cbuffer info in comments isn't present for them.I'm guessing this won't be merged, but I hope this might help people trying to use this in the future.