Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some code I added to make OpenApi reader work on my files #26

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

bocasti
Copy link
Contributor

@bocasti bocasti commented Aug 4, 2020

No description provided.

@bocasti bocasti requested a review from noha August 4, 2020 08:20
@noha
Copy link
Member

noha commented Aug 4, 2020

I don't get what this should fix. The primitive schema should not be visited because it rather considered to be abstract. As for the OALink this covers existing bugs. Can you provide me with the file you want to read instead?

@bocasti
Copy link
Contributor Author

bocasti commented Aug 4, 2020

So I added a test for each case:

  • testParsingSchemaMinItems => for the #minItems: method
  • testParsingResponseWithLinks => for the OALink mapping
  • testParsingOpenAPIWithEnum => for the #acceptOpenApi: method

@noha
Copy link
Member

noha commented Aug 4, 2020

I don't get why you make extension methods here for JSONSchema. Look at zweidenker/JSONSchema#40 that adds minItems and maxItems. What else needs to be done?

@noha
Copy link
Member

noha commented Aug 6, 2020

Can remove the minItem and json schema stuff please?

@bocasti
Copy link
Contributor Author

bocasti commented Aug 6, 2020

Ok, i just

  • removed one useless test related to this #miItems: stuff
  • removed my "hacks" in OALink and PrimitiveSchema

There should now be 2 test failing, which i think highlights 2 issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants