Fix event handler in case no key is specified. #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The way it was checking for no keys was wrong since `"".split(" ")` returns
an Array with a single empty string, checking for `keys.length` isn't enough.
Bug was introduced when changed the way plugin works to use namespaces.
zuriby
added a commit
that referenced
this pull request
Mar 27, 2012
Fix event handler in case no key is specified.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way it was checking for no keys was wrong since
"".split(" ")returnsan Array with a single empty string, checking for
keys.lengthisn't enough.Bug was introduced when changed the way plugin works to use namespaces.
I should have tested it earlier, sorry.
This might be related with #23 (never tested it)