Skip to content

[WIP] message: Improve muted sender design. #34794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

apoorvapendse
Copy link
Collaborator

@apoorvapendse apoorvapendse commented Jun 2, 2025

Fixes: #32945.

CZO: #design > muted users

Screenshots and screen captures:

light dark
image image

In a mobile breakpoint we can hide the message and just have something like this:

I am doing this with cq_sm_min as the breakpoint for now.

light dark
image image

I hid the reveal label at the cq_mm_min breakpoint to avoid truncating "Muted user" on small screens and reduce visual clutter.
Feedback welcome.

Device: iPhone 12 Pro (390x844)

Without breakpoint With breakpoint
without_breakpoint_(iPhone 12 Pro) with_breakpoint_iPhone 12 Pro

dark_mode_large_screen
light_mode_large_screen
dark_mode_responsive
light_mode_responsive

Self-review checklist
  • Self-reviewed the changes for clarity and maintainability
    (variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

  • Explains differences from previous plans (e.g., issue description).
  • Highlights technical choices and bugs encountered.
  • Calls out remaining decisions and concerns.
  • Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

  • Each commit is a coherent idea.
  • Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

  • Visual appearance of the changes.
  • Responsiveness and internationalization.
  • Strings and tooltips.
  • End-to-end functionality of buttons, interactions and flows.
  • Corner cases, error conditions, and easily imagined bugs.

@apoorvapendse apoorvapendse marked this pull request as draft June 2, 2025 11:55
@apoorvapendse apoorvapendse force-pushed the improve-muted-sender-ui branch 2 times, most recently from 27da778 to 19804a2 Compare June 2, 2025 12:23
@apoorvapendse
Copy link
Collaborator Author

@whilstsomebody, can you do a buddy review if you find time?
Thanks.

@apoorvapendse apoorvapendse force-pushed the improve-muted-sender-ui branch from 19804a2 to 48c9f1a Compare June 2, 2025 13:18
@whilstsomebody
Copy link
Collaborator

Tag me again when this is ready for a review.

@apoorvapendse apoorvapendse force-pushed the improve-muted-sender-ui branch from 48c9f1a to eaa498b Compare June 3, 2025 06:11
@apoorvapendse
Copy link
Collaborator Author

tagging @alya, @terpimost for a design review

@apoorvapendse apoorvapendse force-pushed the improve-muted-sender-ui branch 2 times, most recently from 6a8d7a0 to b38fc49 Compare June 4, 2025 12:05
@chrisbobbe
Copy link
Contributor

How about "Muted user" in place of "Muted sender"? That's our plan in mobile; the fact that it's the sender is already communicated by the position of the text. (Thanks @sm-sayedi for mentioning this at zulip/zulip-flutter#1429 (comment) )

@apoorvapendse apoorvapendse force-pushed the improve-muted-sender-ui branch from b38fc49 to 36b317f Compare June 6, 2025 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve design of messages by muted sender
4 participants