-
Notifications
You must be signed in to change notification settings - Fork 329
Upgrade Flutter, packages and Android build dependencies #1846
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There is an update for Android Gradle Plugin too (8.12 -> 8.13), but updating it seems to cause build issues because of EDIT: Here are the logs for Logs
|
cc0428e
to
3b164f1
Compare
Thanks for taking care of this! These all look good modulo the CI failure, which we're discussing at #mobile-team > CI failing after Flutter upgrade. So once that's resolved or worked around, this will be ready to merge. |
3b164f1
to
d8cffc9
Compare
This is ready for review now @gnprice, PTAL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Comments below.
git clone --depth=3000 -b main https://github.com/flutter/flutter ~/flutter | ||
git clone --filter=blob:none -b main https://github.com/flutter/flutter ~/flutter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ci: Prefer `--filter=blob:none` over `--depth=N`
Flutter upstream changed it's version number calculation and
it now doesn't play well with "shallow clone".
That means this is needed before the Flutter upgrade, right? So it should come before that commit, to avoid having a commit where things are broken.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's also a similar --depth
in the other workflow in this directory. Should that be updated the same way?
fi | ||
fi | ||
|
||
# Check the commit is an acceptable commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This check would still work fine, right? I believe it's just the "Check the version name matches the commit ID" step that's affected.
Flutter upstream changed it's version number calculation and it now doesn't play well with "shallow clone". CZO discussion: https://chat.zulip.org/#narrow/channel/243-mobile-team/topic/CI.20failing.20after.20Flutter.20upgrade/with/2258300
Flutter upstream changed it's version number format so this check will need to be updated to accommodate for that, but we leave that as a follow up (see zulip#1851). So, remove this check for now.
This commit is the result of the following commands: flutter pub upgrade --major-versions firebase_messaging firebase_core tools/upgrade pod Changelogs: https://pub.dev/packages/firebase_core/changelog#410 https://pub.dev/packages/firebase_messaging/changelog#1601 Notable changes include bump to Firebase Android BoM (34.0.0 to 34.1.0) and Firebase iOS SDK (12.0.0 to 12.2.0), changelog for those are at: https://firebase.google.com/support/release-notes/android https://firebase.google.com/support/release-notes/ios For Android SDK, no changes in the FCM component (the only one we use). For iOS SDK, one runtime crash fix for apps built with (not yet released) Xcode 26: firebase/firebase-ios-sdk#15159 which doesn't affect us, as probably no one has tried to build with Xcode 26 Beta yet.
This commit is the result of the following commands: flutter pub upgrade --major-versions pigeon tools/check --all-files --fix pigeon Changelog: https://pub.dev/packages/pigeon/changelog#2601 Couple of changes and documentation updates for `@ProxyApi` APIs, which we do not use.
This commit is the result of the following command: flutter pub upgrade --major-versions device_info_plus Changelog: https://pub.dev/packages/device_info_plus/changelog#1200 One breaking change is removal of `serialNumber` from `AndroidDeviceInfo`, which doesn't affect as we do not use it.
This commit is the result of the following commands: flutter pub upgrade --major-versions package_info_plus tools/upgrade pod Changelog: https://pub.dev/packages/package_info_plus/changelog#900
This commit is the result of the following command: flutter pub upgrade --major-versions share_plus Changelog: https://pub.dev/packages/share_plus/changelog#1200 One notable change is that it fixes a bug that occurs only on iOS 26: fluttercommunity/plus_plugins#3631
Changelog: https://kotlinlang.org/docs/whatsnew2220.html Highlights: * Mostly experimental changes. * One notable change is improved incremental compilation for Kotlin/JVM but currently experimental: - https://kotlinlang.org/docs/whatsnew2220.html#preview-improved-incremental-compilation-for-kotlin-jvm * And one breaking change for `kapt.use.k2` property, which we do not use.
d8cffc9
to
b053e79
Compare
Thanks for the review @gnprice! Pushed an update, PTAL. |
Flutter notable commits