Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update container styling: added border and shadow for better UI #1295

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

yashrajpu
Copy link

@yashrajpu yashrajpu commented Jan 21, 2025

Updated container styling to improve UI/UX.

  • Added a border-top with colour var(--border-bar) for a cleaner separation.
  • Included a shadow effect to enhance the appearance of the component in dark mode.
  • Adjusted for light theme compatibility by using a transparent shadow.
Screenshot 2025-01-21 at 1 20 12 PM

fixes:- #1207

@sm-sayedi
Copy link
Collaborator

@yashrajpu The PR description mentions that it fixes #1233! Are you sure that it's not misspelled because that one is already a PR, not an issue? 🙂

@yashrajpu
Copy link
Author

Yes, that task is assigned to her. I notice that when I create a pull request, I also want to check the CI errors we all are facing when creating pull requests.

@sm-sayedi
Copy link
Collaborator

You can safely close this PR as it is not intended to be merged, that way it's easy for maintainers to skip it. Also, #1290 is intended to solve those CI errors!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants