Add conditional UI for displaying messages or default text #1292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…https://github.com/yashrajpu/zulip-flutter into InboxPage-Design-implement-appearance-when-empty#386
|
check this one |
yashrajpu
deleted the
InboxPage-Design-implement-appearance-when-empty#386
branch
|
It looks like you closed this PR and opened a new one (#1294) for the same feature. We usually prefer not to do that; just force-push to the same branch to update the PR, instead of closing it and opening a new one. |
|
I tried that, but I'm still encountering a CI error. I don’t see any other option, so I created a new PR. I also attempted to rebase, but that didn’t work for me, so I manually resolved the errors in my case. Please check the new PR. |
yashrajpu
restored the
InboxPage-Design-implement-appearance-when-empty#386
branch
|
For the future, the |
|
I used 'git help pr request' and they suggested making a new PR. |
|
Who suggested making a new PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #381
This pull request (PR) addresses issue #386 and enhances the user interface by introducing a conditional feature for displaying messages.
If messages are available, they are displayed in the UI. If no messages exist, a default text is shown instead. This improvement enhances the user experience by providing clear feedback when no messages are present.
Changes Made:
Testing:
Figma link:-
The updated UI aligns with the Figma design provided here
[Figma Design Link]
(https://www.figma.com/design/1JTNtYo9memgW7vV6d0ygq/Zulip-Mobile?node-id=5966-176642&p=f&t=gdUmGEmNiTNiCHVf-0)
Ensured consistent behaviour across various screen sizes and edge cases.
Screenshots:
Old image:
New image:
