-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reactions: Add sheet to view who reracted to a message. #1243
base: main
Are you sure you want to change the base?
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Thanks! This PR needs tests. Also, please reorder the two commits, so the commit that adds the icon comes first. That way the icon will be available for the commit that adds the feature. |
3667ec4
to
6bfe471
Compare
@chrisbobbe I've reordered the commits and written the tests for the same. Please take a look. Thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Comments below from a partial review.
Also, a question for you 🙂: what happens if you're looking at the tab for a particular reaction, and then the last vote for that reaction is removed?
176c00a
to
dde36b5
Compare
I’ve addressed all the requested changes and marked them as resolved. As per the conversation here, I’ve implemented the live UI using the As for the question:
Currently, when the last vote for a reaction is removed, the corresponding tab disappears, and the view switches to the previous tab. If there are no remaining reactions, a message saying 'No reactions yet' is shown. Does this behavior seem appropriate? |
Yes, that sounds reasonable. Thanks for explaining! |
0e53322
to
ec9196d
Compare
ec9196d
to
dc91925
Compare
Description
This pull request introduces a Reaction List sheet which can be accessed from either the context menu or by long pressing the reaction chips. Currently the app shows who reacted when there are up to 3 of them. But once there are more, we just show counts, and the user may want to see specifically who left the reactions.
Related Issues
Closes #740
Screenshots