Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reactions: Add sheet to view who reracted to a message. #1243

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

chimnayajith
Copy link

@chimnayajith chimnayajith commented Dec 31, 2024

Description

This pull request introduces a Reaction List sheet which can be accessed from either the context menu or by long pressing the reaction chips. Currently the app shows who reacted when there are up to 3 of them. But once there are more, we just show counts, and the user may want to see specifically who left the reactions.

Related Issues

Closes #740

Screenshots

reaction_list
photo_2024-12-31_22-15-18

@chrisbobbe

This comment was marked as outdated.

@chrisbobbe
Copy link
Collaborator

Thanks! This PR needs tests.

Also, please reorder the two commits, so the commit that adds the icon comes first. That way the icon will be available for the commit that adds the feature.

@chimnayajith chimnayajith force-pushed the reaction-list branch 3 times, most recently from 3667ec4 to 6bfe471 Compare January 16, 2025 05:33
@chimnayajith
Copy link
Author

chimnayajith commented Jan 16, 2025

@chrisbobbe I've reordered the commits and written the tests for the same. Please take a look. Thank you.

Copy link
Collaborator

@chrisbobbe chrisbobbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Comments below from a partial review.

Also, a question for you 🙂: what happens if you're looking at the tab for a particular reaction, and then the last vote for that reaction is removed?

assets/l10n/app_en.arb Outdated Show resolved Hide resolved
assets/icons/reactions.svg Outdated Show resolved Hide resolved
lib/widgets/emoji_reaction.dart Outdated Show resolved Hide resolved
lib/widgets/emoji_reaction.dart Outdated Show resolved Hide resolved
@chimnayajith chimnayajith force-pushed the reaction-list branch 2 times, most recently from 176c00a to dde36b5 Compare January 24, 2025 16:41
@chimnayajith
Copy link
Author

I’ve addressed all the requested changes and marked them as resolved.

As per the conversation here, I’ve implemented the live UI using the MessgeListView getter .

As for the question:

What happens if you're viewing the tab for a particular reaction, and then the last vote for that reaction is removed?

Currently, when the last vote for a reaction is removed, the corresponding tab disappears, and the view switches to the previous tab. If there are no remaining reactions, a message saying 'No reactions yet' is shown. Does this behavior seem appropriate?

@chrisbobbe
Copy link
Collaborator

Currently, when the last vote for a reaction is removed, the corresponding tab disappears, and the view switches to the previous tab. If there are no remaining reactions, a message saying 'No reactions yet' is shown. Does this behavior seem appropriate?

Yes, that sounds reasonable. Thanks for explaining!

@chimnayajith chimnayajith force-pushed the reaction-list branch 2 times, most recently from 0e53322 to ec9196d Compare February 1, 2025 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

See who left an emoji reaction
2 participants