Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

See who left an emoji reaction #740

Open
gnprice opened this issue Jun 18, 2024 · 8 comments · May be fixed by #1243 or #1283
Open

See who left an emoji reaction #740

gnprice opened this issue Jun 18, 2024 · 8 comments · May be fixed by #1243 or #1283
Labels
a-msglist The message-list screen, except what's label:a-content
Milestone
M6: Post-launch

Comments

@gnprice
Copy link
Member

gnprice commented Jun 18, 2024 •
edited by chrisbobbe
Loading

I.e., this Zulip feature:
https://zulip.com/help/emoji-reactions#viewing-who-reacted-to-a-message

This is less critical than it would have been years ago, because we already show the names of who reacted when there are up to 3 of them. But once there are more, we just show counts, and the user may want to see specifically who left the reactions.

Design

The design for this is in Figma: https://www.figma.com/design/1JTNtYo9memgW7vV6d0ygq/Zulip-Mobile?node-id=5878-1516&t=mBhvNBmPS0sBxGKG-0

Screenshot:
image

Design discussion: https://chat.zulip.org/#narrow/channel/530-mobile-design/topic/View.20Reactions.20ModalBottomSheet/near/2013460

The green dot (presence indicator) on the avatars is out of scope for this issue.
@gnprice gnprice added the a-msglist The message-list screen, except what's label:a-content label Jun 18, 2024
@gnprice gnprice added this to the Beta 3: Summer 2024 milestone Jun 18, 2024
@chimnayajith
Copy link

Can I work on this?

@chrisbobbe
Copy link
Collaborator

Please take a look at the Zulip project's guide to getting involved with the code:

https://zulip.readthedocs.io/en/latest/contributing/contributing.html#your-first-codebase-contribution
https://zulip.readthedocs.io/en/latest/contributing/contributing.html#picking-an-issue-to-work-on

chimnayajith pushed a commit to chimnayajith/zulip-flutter that referenced this issue Dec 23, 2024
reactions: Add sheet to view who reacted to a message
8808abe 
Fixed zulip#740
chimnayajith pushed a commit to chimnayajith/zulip-flutter that referenced this issue Dec 23, 2024
reactions: Add sheet to view who reacted to a message
37dad96 
Fixed zulip#740
chimnayajith pushed a commit to chimnayajith/zulip-flutter that referenced this issue Dec 31, 2024
reactions: Add sheet to view who reacted to a message
cefe10f 
Fixes zulip#740
chimnayajith pushed a commit to chimnayajith/zulip-flutter that referenced this issue Dec 31, 2024
reactions: Add sheet to view who reacted to a message
bb5c955 
Fixes zulip#740
@chimnayajith chimnayajith linked a pull request Dec 31, 2024 that will close this issue
Open
@chrisbobbe

This comment was marked as resolved.

Sign in to view
@chrisbobbe

This comment was marked as resolved.

Sign in to view
@chrisbobbe

This comment was marked as resolved.

Sign in to view
@PIG208 PIG208 linked a pull request Jan 15, 2025 that will close this issue
Open
@E-m-i-n-e-n-c-e
Copy link

#1283

Image

It only requires some minor changes. IMO I think it already looks pretty good

chimnayajith pushed a commit to chimnayajith/zulip-flutter that referenced this issue Jan 16, 2025
reactions: Add sheet to view who reacted to a message
afd736a 
Fixes zulip#740
chimnayajith pushed a commit to chimnayajith/zulip-flutter that referenced this issue Jan 16, 2025
reactions: Add sheet to view who reacted to a message
3667ec4 
Fixes zulip#740
chimnayajith pushed a commit to chimnayajith/zulip-flutter that referenced this issue Jan 16, 2025
reactions: Add sheet to view who reacted to a message
6bfe471 
Fixes zulip#740
@E-m-i-n-e-n-c-e
Copy link

E-m-i-n-e-n-c-e commented Jan 16, 2025 •
edited
Loading

How should the green dot indicator at the bottom right work. Rn I am showing the green indicator to all the users who are active(haven't deactivated their account).

In the react app it uses the user's status and displays the status symbol. But there is no such thing in the Figma design .
If i have to show and hide the green dot indicator based values of the user status. Could you specify which values should hide it and which values should show the green dot indicator

@chrisbobbe
Copy link
Collaborator

Ah thanks for the question! I've updated the issue description, adding:

The green dot (presence indicator) on the avatars is out of scope for this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
a-msglist The message-list screen, except what's label:a-content
Projects
Flutter app
Status: No status
Milestone
M6: Post-launch
4 participants
@gnprice @chrisbobbe @chimnayajith @E-m-i-n-e-n-c-e