-
-
Notifications
You must be signed in to change notification settings - Fork 391
integration-docs: Update the RSS integration doc. #872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Niloth-p - Thanks again for this integration doc update! Let me know if you have any questions about my review comments! Some here are reflections on other pending integration doc changes that are similar.
zulip/integrations/rss/doc.md
Outdated
location is `~/.cache/zulip-rss`. | ||
|
||
- `--stream`: The name of the Zulip channel you want to receive | ||
notifications in. By default, messages are sent to the `rss` channel. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should be consistent in using quotes or backticks for channel names across all integration docs. Here we use backticks, but in the SVN or IRC updates we used quotes.
Thank you for the review! Updated as recommended. |
|
||
!!! tip "" | ||
|
||
Note that [the Zapier integration][1] is usually a simpler way to | ||
[The Zapier integration][1] is usually a simpler way to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this only if you're OK with all the messages going to the same topic? If so, it should be something like:
[The Zapier integration][1] is usually a simpler way to | |
For sending messages to a single topic, [the Zapier integration][1] is a simpler way to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not particularly, Zapier can send DMs or construct the topic name from the payload too.
I think the direct integration may be preferred by folks who want to customize the integration, or use the --unwrap
or --math
options or wish to send DMs without sharing their credentials with Zapier.
zulip/integrations/rss/doc.md
Outdated
`--feed-file` [option](#configuration-options) to the integration | ||
script. | ||
|
||
1. You can run the bot to send summaries of RSS entries from your favorite |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1. You can run the bot to send summaries of RSS entries from your favorite | |
1. Run the bot to send summaries of RSS entries from your favorite |
|
||
`{{ integration_path }}/rss-bot` | ||
|
||
1. Optionally, pass command-line arguments to re-configure the integration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1. Optionally, pass command-line arguments to re-configure the integration. | |
1. Pass command-line arguments to re-configure the integration. See [the configuration options](#configuration-options below. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason for having the "Optionally" word, and mention the "list of options" is that there are some integrations that require all of their supported command-line arguments. We're trying to say that these command-line arguments are not necessary, but if the user wants to configure it further, they can. And the full list of options is available below, but the user can choose to use some of those options without using the rest.
I've retained the "Optionally" word, but rephrased the link sentence as suggested.
zulip/integrations/rss/doc.md
Outdated
See [the configuration options](#configuration-options) for the list of | ||
options. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See [the configuration options](#configuration-options) for the list of | |
options. |
zulip/integrations/rss/doc.md
Outdated
1. Configure a crontab entry to keep the integration running. | ||
|
||
This sample crontab entry processes feeds stored in the default | ||
location and posts to the `rss` topic in the `#news` channel every 5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
location and posts to the `rss` topic in the `#news` channel every 5 | |
location and posts to the `rss` topic in the **#news** channel every 5 |
zulip/integrations/rss/doc.md
Outdated
location is `~/.cache/zulip-rss`. | ||
|
||
- `--stream`: The name of the Zulip channel you want to receive | ||
notifications in. By default, messages are sent to the `#rss` channel. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
notifications in. By default, messages are sent to the `#rss` channel. | |
notifications in. By default, messages are sent to the **#rss** channel. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
||
!!! tip "" | ||
|
||
Note that [the Zapier integration][1] is usually a simpler way to | ||
[The Zapier integration][1] is usually a simpler way to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not particularly, Zapier can send DMs or construct the topic name from the payload too.
I think the direct integration may be preferred by folks who want to customize the integration, or use the --unwrap
or --math
options or wish to send DMs without sharing their credentials with Zapier.
|
||
`{{ integration_path }}/rss-bot` | ||
|
||
1. Optionally, pass command-line arguments to re-configure the integration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason for having the "Optionally" word, and mention the "list of options" is that there are some integrations that require all of their supported command-line arguments. We're trying to say that these command-line arguments are not necessary, but if the user wants to configure it further, they can. And the full list of options is available below, but the user can choose to use some of those options without using the rest.
I've retained the "Optionally" word, but rephrased the link sentence as suggested.
OK, I'm happy for other reviewers (@timabbott ?) to take the next look. |
Screenshots
RSS doc link


Self-review checklist
(variable names, code reuse, readability, etc.).
Communicate decisions, questions, and potential concerns.
Individual commits are ready for review (see commit discipline).
Completed manual review and testing of the following: