Skip to content

integration-docs: Update the RSS integration doc. #872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Niloth-p
Copy link
Contributor

@Niloth-p Niloth-p commented Jun 5, 2025

Screenshots

RSS doc link
image
image

Self-review checklist
  • Self-reviewed the changes for clarity and maintainability
    (variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

  • Explains differences from previous plans (e.g., issue description).
  • Highlights technical choices and bugs encountered.
  • Calls out remaining decisions and concerns.
  • Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

  • Each commit is a coherent idea.
  • Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

  • Visual appearance of the changes.
  • Responsiveness and internationalization.
  • Strings and tooltips.
  • End-to-end functionality of buttons, interactions and flows.
  • Corner cases, error conditions, and easily imagined bugs.

Copy link

@laurynmm laurynmm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Niloth-p - Thanks again for this integration doc update! Let me know if you have any questions about my review comments! Some here are reflections on other pending integration doc changes that are similar.

location is `~/.cache/zulip-rss`.

- `--stream`: The name of the Zulip channel you want to receive
notifications in. By default, messages are sent to the `rss` channel.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should be consistent in using quotes or backticks for channel names across all integration docs. Here we use backticks, but in the SVN or IRC updates we used quotes.

@Niloth-p
Copy link
Contributor Author

Thank you for the review! Updated as recommended.
I've switched to using backticks instead of double quotes for channel and topic names, and added the prefix # in front of channel names (because that's the convention in the Help docs - example).

Screenshots

image
image


!!! tip ""

Note that [the Zapier integration][1] is usually a simpler way to
[The Zapier integration][1] is usually a simpler way to
Copy link
Contributor

@alya alya Jul 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this only if you're OK with all the messages going to the same topic? If so, it should be something like:

Suggested change
[The Zapier integration][1] is usually a simpler way to
For sending messages to a single topic, [the Zapier integration][1] is a simpler way to

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not particularly, Zapier can send DMs or construct the topic name from the payload too.

I think the direct integration may be preferred by folks who want to customize the integration, or use the --unwrap or --math options or wish to send DMs without sharing their credentials with Zapier.

`--feed-file` [option](#configuration-options) to the integration
script.

1. You can run the bot to send summaries of RSS entries from your favorite
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
1. You can run the bot to send summaries of RSS entries from your favorite
1. Run the bot to send summaries of RSS entries from your favorite


`{{ integration_path }}/rss-bot`

1. Optionally, pass command-line arguments to re-configure the integration.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
1. Optionally, pass command-line arguments to re-configure the integration.
1. Pass command-line arguments to re-configure the integration. See [the configuration options](#configuration-options below.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason for having the "Optionally" word, and mention the "list of options" is that there are some integrations that require all of their supported command-line arguments. We're trying to say that these command-line arguments are not necessary, but if the user wants to configure it further, they can. And the full list of options is available below, but the user can choose to use some of those options without using the rest.

I've retained the "Optionally" word, but rephrased the link sentence as suggested.

Comment on lines 45 to 46
See [the configuration options](#configuration-options) for the list of
options.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
See [the configuration options](#configuration-options) for the list of
options.

1. Configure a crontab entry to keep the integration running.

This sample crontab entry processes feeds stored in the default
location and posts to the `rss` topic in the `#news` channel every 5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
location and posts to the `rss` topic in the `#news` channel every 5
location and posts to the `rss` topic in the **#news** channel every 5

location is `~/.cache/zulip-rss`.

- `--stream`: The name of the Zulip channel you want to receive
notifications in. By default, messages are sent to the `#rss` channel.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
notifications in. By default, messages are sent to the `#rss` channel.
notifications in. By default, messages are sent to the **#rss** channel.

Copy link
Contributor Author

@Niloth-p Niloth-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the review!

Screenshots

image
image


!!! tip ""

Note that [the Zapier integration][1] is usually a simpler way to
[The Zapier integration][1] is usually a simpler way to
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not particularly, Zapier can send DMs or construct the topic name from the payload too.

I think the direct integration may be preferred by folks who want to customize the integration, or use the --unwrap or --math options or wish to send DMs without sharing their credentials with Zapier.


`{{ integration_path }}/rss-bot`

1. Optionally, pass command-line arguments to re-configure the integration.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason for having the "Optionally" word, and mention the "list of options" is that there are some integrations that require all of their supported command-line arguments. We're trying to say that these command-line arguments are not necessary, but if the user wants to configure it further, they can. And the full list of options is available below, but the user can choose to use some of those options without using the rest.

I've retained the "Optionally" word, but rephrased the link sentence as suggested.

@alya
Copy link
Contributor

alya commented Jul 2, 2025

OK, I'm happy for other reviewers (@timabbott ?) to take the next look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants