-
-
Notifications
You must be signed in to change notification settings - Fork 391
Update the doc of the IRC bridge integration. #870
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Niloth-p - Thanks for working on updating this doc! Overall, these updates look good. I had a few thoughts on revisions/tweaks that could make the instructions clearer. Let me know if you have any questions!
Thank you for the review! Updated as recommended. |
1. [Subscribe the bot][subscribe-channels] to the Zulip channel that will | ||
contain the mirror. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1. [Subscribe the bot][subscribe-channels] to the Zulip channel that will | |
contain the mirror. | |
1. [Subscribe the bot][subscribe-channels] to the Zulip channel where IRC messages should be mirrored. |
Is this 1-way mirroring or 2-way mirroring? Everything in the doc sounded like 1-way mirroring until I got to the screenshots. |
Thank you for the review! Updates:
|
Why is it |
Passing on to @timabbott for review. |
That screenshot is pretty old. It's probably just a random bot name, I'm not sure. I would have expected the bot's nick to end with "_zulip" too, to avoid echoing. We'll need to update the IRC screenshot in sync with the Zulip screenshot, which we would update once we have support for generating screenshots of message threads. So, the image updates would go in a separate update later. |
Screenshots
IRC doc link


Self-review checklist
(variable names, code reuse, readability, etc.).
Communicate decisions, questions, and potential concerns.
Individual commits are ready for review (see commit discipline).
Completed manual review and testing of the following: