Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modified code for google calendar integration #848

Closed
wants to merge 6 commits into from
Closed

modified code for google calendar integration #848

wants to merge 6 commits into from

Conversation

octocamocoder47
Copy link

@octocamocoder47 octocamocoder47 commented Jan 4, 2025 •
edited
Loading

modified code for google calendar integration according to google calendar new API manual

Fixes: #847 (#847 )

How did you test this PR?

I couldn't test PR because I don't have api keys and proper env setup to test it.

  • Self-reviewed the changes for clarity and maintainability
    (variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

  • Explains differences from previous plans (e.g., issue description).
  • Highlights technical choices and bugs encountered.
  • Calls out remaining decisions and concerns.
  • Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

  • Each commit is a coherent idea.
  • Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

  • Visual appearance of the changes.
  • Responsiveness and internationalization.
  • Strings and tooltips.
  • End-to-end functionality of buttons, interactions and flows.
  • Corner cases, error conditions, and easily imagined bugs.

@whilstsomebody
Copy link

@octocamocoder47 ,please give some time reading our contribution guidelines and commit discipline.

@octocamocoder47
Copy link
Author

I have tested the code thoroughly below is link to demo.

https://drive.google.com/file/d/1isjB0xGirL0Bpn0SGRz0cO8RZS58rQFd/view?usp=sharing

@octocamocoder47
Copy link
Author

This is link to the reminder script.
https://drive.google.com/file/d/1OvqqGw8jSNWe9iudZsoviqw9665E-9tw/view?usp=sharing

feel free to ask if file is not accessible.

@octocamocoder47 octocamocoder47 changed the title modified code for google calendar integration api: Exclude None values from request payload in Endpoint class. Description: Refactored the Endpoint class to exclude parameters with None values from the request payload. This ensures cleaner API interactions and avoids unintended behavior, improving code reliability and alignment with best practices. Jan 11, 2025
@octocamocoder47 octocamocoder47 changed the title api: Exclude None values from request payload in Endpoint class. Description: Refactored the Endpoint class to exclude parameters with None values from the request payload. This ensures cleaner API interactions and avoids unintended behavior, improving code reliability and alignment with best practices. api: Exclude None values from request payload in Endpoint class. \nDescription: Refactored the Endpoint class to exclude parameters with None values from the request payload. This ensures cleaner API interactions and avoids unintended behavior, improving code reliability and alignment with best practices. Jan 11, 2025
@octocamocoder47 octocamocoder47 changed the title api: Exclude None values from request payload in Endpoint class. \nDescription: Refactored the Endpoint class to exclude parameters with None values from the request payload. This ensures cleaner API interactions and avoids unintended behavior, improving code reliability and alignment with best practices. api: Exclude None values from request payload in Endpoint class. Description: Refactored the Endpoint class to exclude parameters with None values from the request payload. This ensures cleaner API interactions and avoids unintended behavior, improving code reliability and alignment with best practices. Jan 11, 2025
@octocamocoder47 octocamocoder47 changed the title api: Exclude None values from request payload in Endpoint class. Description: Refactored the Endpoint class to exclude parameters with None values from the request payload. This ensures cleaner API interactions and avoids unintended behavior, improving code reliability and alignment with best practices. modified code for google calendar integration according to the new google calendar api manual Jan 11, 2025
@octocamocoder47 octocamocoder47 changed the title modified code for google calendar integration according to the new google calendar api manual modified code for google calendar integration Jan 11, 2025
@mpagler @pransh62390
api: Exclude None values from request payload in Endpoint class.
0e671ba 
Description:

Refactored the Endpoint class to exclude parameters with None values from the request payload. This ensures cleaner API interactions and avoids unintended behavior, improving code reliability and alignment with best practices.
@pransh62390 pransh62390 force-pushed the google-calendar-integration-847 branch from c4ac2ec to 0e671ba Compare January 11, 2025 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
size: XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update the Google Calendar integration
6 participants
@octocamocoder47 @whilstsomebody @zulipbot @pransh62390 @X1Vi @mpagler