Switch to Docker secrets for secrets, and compose.override.yaml for configuration. #527
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Tested with single quotes, double quotes, and dollar signs in all of the password strings. |
alexmv
force-pushed
the
secrets
branch
6 times, most recently
from
26a7148 to
bee08f7
Compare
alexmv
changed the title
The parameters of this match the Helm chart's startupProbe/livenessProbe.
This allows specifying the app_protocol. This doesn't provide any explicit utility at the moment, however.
Future changes in this Dockerfile will depend on not-yet-released Zulip changes.
The latter is Zulip-specific, and being removed in `main`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #272
Fixes: #468
Fixes: #143
Fixes: #238
This still needs a bunch of documentation updates.