Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: doc typo #198

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: doc typo #198

wants to merge 1 commit into from

Conversation

Aqours
Copy link

@Aqours Aqours commented Dec 11, 2019

issues #125

@codecov
Copy link

codecov bot commented Dec 11, 2019

Codecov Report

Merging #198 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #198   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          30     30           
  Lines         121    121           
  Branches       31     31           
=====================================
  Hits          121    121

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bbdb721...c0d115d. Read the comment docs.

@@ -130,7 +130,7 @@ The official recommendation for running `common-tags` is as follows:

- [Node.js](https://nodejs.org/en/download/) v5.0.0 or higher
- In order to use `common-tags`, your environment will also need to support ES2015 tagged templates ([pssst… check Babel out](http://babeljs.io))
- You might also want to [polyfill some features](https://github.com/zloirock/core-js) if you plan on supporting older browsers: `Array.prototype.includes`
- You might also want to [polyfill some features](https://github.com/zloirock/core-js) if you plan on supporting older browsers: `String.prototype.includes`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you include both? As in

Suggested change
- You might also want to [polyfill some features](https://github.com/zloirock/core-js) if you plan on supporting older browsers: `String.prototype.includes`
- You might also want to [polyfill some features](https://github.com/zloirock/core-js) if you plan on supporting older browsers: `Array.prototype.includes`, `String.prototype.includes`

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The string one is used in splitStringTransformer, and the array one is used eg. in trimResultTransformer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants