Feature/sticky player #24
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/zpapoo/ncha-frontend/p1aq7bhpe |
JaeYeopHan
approved these changes
May 3, 2020
| } | ||
| ` | ||
|
|
||
| const Container = styled<'div', {isVisible: boolean}>('div')` |
There was a problem hiding this comment.
how about this?
Suggested change
| const Container = styled<'div', {isVisible: boolean}>('div')` | |
| const Container = styled.div<{ isVisible: boolean }>` |
| @@ -8,7 +9,7 @@ import { | |||
| playerActions, | |||
| } from 'features/playerSlice' | |||
| import { useFetchWithStore } from 'hooks/useFetch' | |||
| import React from 'react' | |||
| import React from 'react' | |||
There was a problem hiding this comment.
Suggested change
| import React from 'react' | |
| import React from 'react' |
| { | ||
| currentComment.map((comment: Comment) => { | ||
| const { kind, contents, time, id } = comment | ||
| <div id={COMMENT_WRAPPER}> |
| import { useCallback, useEffect, useState } from 'react' | ||
|
|
||
| interface Params { | ||
| handleWheel: (params?: any) => void; |
There was a problem hiding this comment.
how about this?
WheelEventHandler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Desc
comment화면에서 스크롤에 따라 상단 Player를 fold -> unfold하는 애니메이션을 추가했습니다.Demo
재생버튼이 닫힌 후에 상단 Title이 닫히게 한번 해보고는 싶은데, 조금 어렵네요 ㅠ @JaeYeopHan