Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error handling for server deploy #249

Merged
merged 4 commits into from
Mar 28, 2025
Merged

Conversation

t1m0thyj
Copy link
Member

@t1m0thyj t1m0thyj commented Mar 27, 2025

What It Does

Fixes regressions introduced in #236:

  • SSH profile validation hangs when server binary not found
  • Checksums file not found by zowed and missing ASCII tag
  • Checksums did not match when serialized in different order

How to Test

Same as #236

Review Checklist
I certify that I have:

Additional Comments

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes error handling issues during server deploys by addressing SSH stream event handling and ensuring proper checksum file resolution. The changes update artifact handling commands, modify test expectations for SSH streams, adjust SSH data processing and parsing, and update the checksum file path resolution.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
scripts/buildTools.ts Updates artifact commands to derive file names and paths consistently.
packages/sdk/test/ZSshClient.test.ts Revises SSH stream mocks and adjusts event count expectations in tests.
packages/sdk/src/ZSshClient.ts Refines SSH data handling by listening to both stderr and stdout events.
native/golang/utils/bytes.go Changes checksum file resolution to use the executable's directory.

@t1m0thyj t1m0thyj merged commit 81eefb9 into main Mar 28, 2025
8 checks passed
@t1m0thyj t1m0thyj deleted the fix/deploy-error-handling branch March 28, 2025 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

2 participants