Added the possiblility to pass ets tweak options#8
Open
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the router module to accept ETS tweak options for configuring table concurrency settings while updating supported OTP versions in CI configuration.
- Added a new
new/2function to accept custom ETS tweak options and set default concurrency settings - Refactored table creation to use configurable options instead of hardcoded concurrency settings
- Updated CI configuration to test against newer OTP versions (26, 27, 28) and use actions/checkout@v3
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/router.erl | Added ETS tweak options parameter, default concurrency settings, and refactored table creation |
| .github/workflows/test.yml | Updated OTP versions and checkout action version |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the possiblility to pass ets tweak options
Added
{write_concurrency, auto}as default tweak