Add transcoded download support #290
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Potential solution: download the file in a pseudo fs (like a worker) and after this is done, download the file from the worker via the browser (since the file would then be local this is instant and does not require user consent). This is kinda what mega does |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The length of the stream is invalid (since ffmpeg seek at the beginning of the file to set the correct headers for length, but we already sent this part of the file to the client) so this makes bugged streams on android and players can't display a valid progress bar.
This could be fixed by using another container but only mkv allow all fonts/attachment so...
The other issue is that we don't know how big the file will be so the download can't display a progress bar (on android the current implementation always display -1%)
I wonder if we could just transcode the file completly and then send it.