Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

serialize system error #144

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

serialize system error #144

wants to merge 1 commit into from

Conversation

mrmarone
Copy link

@mrmarone mrmarone commented Feb 7, 2017

Fixed some rare system error.

@mrmarone
serialize system error
0028029 
Fixed some rare system error.
tseaver
tseaver requested changes May 5, 2017
View reviewed changes
Copy link
Member

@tseaver tseaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mrmarone Thanks for the patch. Before reviewing, the PR needs to be passing all tests. In addition, there must be one or more tests added which provoke the error case the patch is trying to solve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tseaver tseaver tseaver requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrmarone @tseaver