Implement multiple examples loading and generation in the Interactive Server. #1367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixes - bug with exactValue validation in interactive example tests. - Use the fileSource attribute in rows to match example file to scenario - Add tests to ensure canonical path is used for matching. - Update existing test for Feature.createContractTestFromExampleFile.
- Use AtomicInteger for unique example file names. - Include TestResult report in case of test failure with testLogs. - Ability to Load and display multiple existing examples. - Ability to Generate additional examples when necessary. - Update ExamplesCommandTest accordingly.
- Update CSS and JS files. - Remove chevronDown and dropdown functionality from drill-downs. - Add and implement Generate more buttons for multiple generations - Functions to dynamically update the examples table and recalculate the row-spans when adding new examples. - Use dynamic serial numbering no reliance on thymeleaf. - Modifications to how data is stored and accessed in JS. - Clean up TestInteractionsLog.combineLog for consistency.
- Group also by content-type when grouping endpoints. - Update updateSpans function in JS to also consider content-type. - Other CSS fixes.
* main: Loading config file from classpath Also in case of env property or classpath checking if the file exists before returning
- This change will be incorporated into a separate PR.
- Rename `atomicCounter` to `exampleFileNamePostFixCounter` to better describe the functionality.
harikrishnan83
approved these changes
Oct 21, 2024
| @@ -14,56 +16,81 @@ class ExamplesView { | |||
| companion object { | |||
| fun getEndpoints(feature: Feature, examplesDir: File): List<Endpoint> { | |||
| val examples = examplesDir.getExamplesFromDir() | |||
| return feature.scenarios.map { | |||
| val example = getExistingExampleFile(it, examples) | |||
| val scenarioExPairList = getScenarioExamplesPairs(feature.scenarios, examples) | |||
There was a problem hiding this comment.
Please expand Ex to Example, will be easier to read
| val example = getExistingExampleFile(it, examples) | ||
| val scenarioExPairList = getScenarioExamplesPairs(feature.scenarios, examples) | ||
|
|
||
| return scenarioExPairList.map { (scenario, ex) -> |
There was a problem hiding this comment.
same as above, expand ex to example
| method = scenario.method, | ||
| responseStatus = scenario.httpResponsePattern.status, | ||
| contentType = scenario.httpRequestPattern.headersPattern.contentType, | ||
| exampleFile = ex?.first, |
There was a problem hiding this comment.
Can we further explode ex to exampleFile and exampleMismatchReason? so that we avoid using first and second
| ) | ||
| }.filterEndpoints().sortEndpoints() |
There was a problem hiding this comment.
any reason we stopped sorting endpoints? was this intentional?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Implement multiple examples loading and generation in the Interactive Server.
Load multiple examples and generate more examples in interactive examples UI.
Why:
Generate Morebutton when there are already existing examplesChecklist: