Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ble): introduce Kconfig option to disable Bluetooth profile advertising #2188

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

xudongzheng
Copy link
Contributor

@xudongzheng xudongzheng commented Mar 7, 2024

CONFIG_ZMK_BLE_PROFILE_ADVERTISING=n can be used to disable profile advertising.

@xudongzheng xudongzheng requested a review from a team as a code owner March 7, 2024 04:35
@xudongzheng xudongzheng force-pushed the bt-no-profile-pr branch 2 times, most recently from 17b001b to 928f82a Compare August 6, 2024 17:57
Copy link

@ayroblu ayroblu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested and verified this works
ayroblu/zmk-config@fc90095...ce2691a
My keyboard types fine, and I no longer see my dongle advertising in bluetooth settings

…rtising

This is useful for dongle mode with only USB output.
@xudongzheng xudongzheng changed the title feat(ble): allow dongle without Bluetooth profiles feat(ble): introduce Kconfig option to disable Bluetooth profile advertising Feb 21, 2025
@xudongzheng
Copy link
Contributor Author

This PR has been reworked such that profile advertising can be disabled with CONFIG_ZMK_BLE_PROFILE_ADVERTISING=n.

This makes configuration slightly less error prone as the user no longer has to make changes to CONFIG_BT_MAX_CONN, since the value ends up being different for dongle and dongleless.

Additionally, some parts of ZMK make the assumption that the number of profiles is non-zero. Having CONFIG_ZMK_SPLIT_BLE_CENTRAL_PERIPHERALS set to CONFIG_BT_MAX_CONN can cause ZMK to behave unexpectedly as a result of that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants