Subscriber aia lints #860
Merged
Subscriber aia lints #860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christopher-henderson
approved these changes
Jun 23, 2024
| type bRAIAAccessMethodAllowed struct{} | ||
|
|
||
| /************************************************************************ | ||
| 7.1.2.7.7 Subscriber Certificate Authority Information Access |
There was a problem hiding this comment.
🙏 thank for putting the full citation in comments. Perhaps I should start asking of this more regularly since I often spend a good chunk of my time hunting these down so that I can double check the interpretation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a few lints from Section 7.1.2.7.7 of BR. This work has been done in close cooperation with D-Trust CA. We would be grateful if you could incorporate this PR into the main project.
Also while looking what is already implemented to avoid duplications, a few corrections have been made and a test has been added to an older lint (e_sub_cert_aia_does_not_contain_ocsp_url) to show the difference between the old lint which is a Pass and the new one (e_aia_ocsp_must_have_http_only) which is an Error for the same certificate.