Skip to content

Commit

Permalink
Fix unquantized solo voice output
Browse files Browse the repository at this point in the history
Without this patch, 1V/oct input into an unquantized solo voice does not
map correctly to output frequency. Instead of mapping whole CV values
(e.g. 2.0 V) to C note, it is mapped to A.

This patch fixes it.

Signed-off-by: Petr Horacek <[email protected]>
  • Loading branch information
phoracek committed Nov 25, 2024
1 parent 9e93010 commit be55def
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
3 changes: 2 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,11 @@ backwards compatibility.

## Unreleased

* Introduce basic detune to the first detune section.
* Tune the output to match 440 Hz at A.
* Fix 1V/oct alignment of unquantized solo voice output.
* Pure Data externals were moved to a [dedicated project](https://github.com/zlosynth/automaton).
* Offer alternative firmware with white key quantization disabled.
* Introduce basic detune to the first detune section.

## 2.2.1

Expand Down
2 changes: 1 addition & 1 deletion lib/src/instrument.rs
Original file line number Diff line number Diff line change
Expand Up @@ -579,7 +579,7 @@ impl<'a> Instrument<'a> {
note.to_freq_f32()
}
} else {
Note::AMinus1.to_freq_f32() * 2.0.powf(voct)
Note::C0.to_freq_f32() * 2.0.powf(voct)
};
self.degrees[last].set_frequency(frequency);

Expand Down

0 comments on commit be55def

Please sign in to comment.