Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Circuit fixes #197

Merged
merged 17 commits into from
May 27, 2024
Merged

Circuit fixes #197

merged 17 commits into from
May 27, 2024

Conversation

saleel
Copy link
Member

@saleel saleel commented May 17, 2024

Description

  • Add missing constrains for length input signals
  • Fix index off by one in AssertZeroPadding
  • Fix param in PoseidonLarge
  • Document input assumptions
  • Remove unused code
  • Remove unnecessary asserts()
  • Fix warnings in Fp due to array size

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I have discussed with the team prior to submitting this PR
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes

@saleel saleel marked this pull request as ready for review May 20, 2024 15:23
@saleel saleel merged commit 95cd901 into main May 27, 2024
5 checks passed
@saleel saleel deleted the circuit-fixes branch May 27, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants