Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix currency formatting throughout app #13015

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

getsnoopy
Copy link

Resolves #12530

Copy link
Member

@MaxHillebrand MaxHillebrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cACK

@soosr
Copy link
Collaborator

soosr commented May 10, 2024

I am not sure about this change. If we displayed the amount with currency signs like $1000, I would be ok with that change.
But since we are using the amount + USD form, even if it is the official way in some countries. Checking now ALL the other applications and exchanges they all display the amounts as we do it now.

So maybe it would be correct for you and some of the other users, but would be definitely confusing for the rest of the world.

@getsnoopy
Copy link
Author

I'm not sure what you mean by "some countries" and "the rest of the world". It's related to the language being used, not the country in which it is being used. In the English language (regardless of country), currency codes and symbols always precede the amount, with symbols being unspaced (e.g., $5, US$5) and codes being spaced (e.g., USD 5). Writing it as 5$ or 5 USD is incorrect.

This can be seen in basically any English style guide or publication, such as newspapers and even apps (see below). Unicode's CLDR specifies this as well.

Screenshot 2024-05-13 212958

(This is a screenshot of the Emirates website.)

There are some crypto apps/websites which incorrectly show the amounts (I don't know why they do this), but it's not all (Nexo does this correctly, for example), and either way, I'm already in the process of getting them fixed.

You seem to be from Hungary, which is a part of the EU, and even the EU clearly has documentation about how to format currency amounts properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Currencies are improperly formatted
3 participants