Pattern-match on types instead of tags in ZPure#runAll #1251
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR optimizes the performance of ZPure by pattern matching on implementation types over tags.
While the reasoning on why this is more performant is still not very clear to me, I've noticed similar issues in Caliban and seem to be related to how the JVM optimizes (or in better terms, fails to optimize) interface dispatches. I've also noticed that ZIO 1.x used the same pattern matching mechanism (via tags), but that was changed to type-based pattern matching in ZIO 2.x
With the changes in this PR, we get a ~20% performance improvement when running ZPure effects.