Remove Consumer::stopConsumption

[guizmaii]

No description provided.

[erikvanoosten]

There is one problem with this approach. When we interrupt the stream, pending commit may not be completed. When we call stopConsumption, the stream can continue to work on whatever it got and complete without errors.

[guizmaii]

@erikvanoosten As explained in Discord, I think it's a user issue, not a zio-kafka issue. See https://discord.com/channels/629491597070827530/629497941719121960/1120624484035067934

[erikvanoosten]

@erikvanoosten As explained in Discord, I think it's a user issue, not a zio-kafka issue. See https://discord.com/channels/629491597070827530/629497941719121960/1120624484035067934

I didn't see that yet. I'll read it!

[svroonland]

If we have a satisfying way to do this in user space and add that to the docs, I'm all for removing this method and the extra complexity it brings. Did you test it already?

[guizmaii]

Did you test it already?

I just started the PR this morning to see what it'd give and what would break.
It needs more work I'll not have time to do this week, focusing on my project.
If you wanna take the subject, go for it :)

Have a look at the discussion I had with a user in Discord. It might be interesting to provide an "interuptor" to the user so that it's easy for them to stop a Stream

For us, it'd probably just be a Promise wrapped in a nice, easy-to-use interface

[guizmaii]

Closed in favour of #941