-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructure consumer group polling runloop (fixes #1470 ) #1471
Restructure consumer group polling runloop (fixes #1470 ) #1471
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Differs in linespace, due to fmt.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please run sbt fmt
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Differs in linespace, due to fmt.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The idea posted in #1470 is to fetch the group metadata after a rebalance. The right place to do this is line 274. Currently, we clear the ref on that line. Instead, we want to fill the ref immediately with the value obtained by calling getConsumerGroupMetadataIfAny
. Other places in Runloop
can then read the ref directly and no longer need to call getConsumerGroupMetadataIfAny
.
I raised another PR, will close this one. But probably we would need to initialise the group metadata ref before first rebalance, there is a test failing. Investigating more: #1474 |
Restructure consumer group polling runloop (fixes #1470 )