Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure consumer group polling runloop (fixes #1470 ) #1471

Conversation

vermas7988
Copy link
Contributor

Restructure consumer group polling runloop (fixes #1470 )

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Differs in linespace, due to fmt.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run sbt fmt.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Differs in linespace, due to fmt.

Copy link
Collaborator

@erikvanoosten erikvanoosten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea posted in #1470 is to fetch the group metadata after a rebalance. The right place to do this is line 274. Currently, we clear the ref on that line. Instead, we want to fill the ref immediately with the value obtained by calling getConsumerGroupMetadataIfAny. Other places in Runloop can then read the ref directly and no longer need to call getConsumerGroupMetadataIfAny.

@vermas7988
Copy link
Contributor Author

The idea posted in #1470 is to fetch the group metadata after a rebalance. The right place to do this is line 274. Currently, we clear the ref on that line. Instead, we want to fill the ref immediately with the value obtained by calling getConsumerGroupMetadataIfAny. Other places in Runloop can then read the ref directly and no longer need to call getConsumerGroupMetadataIfAny.

I raised another PR, will close this one. But probably we would need to initialise the group metadata ref before first rebalance, there is a test failing. Investigating more: #1474

@vermas7988 vermas7988 closed this Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fetch consumer group metadate after a rebalance
2 participants