-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implemented compile time caching for scala 3 #518
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
package benchmarks | ||
|
||
import izumi.reflect.TagGenerator | ||
|
||
object TagCachingBenchmark extends App { | ||
val iterations = 100000 | ||
|
||
// Warm up | ||
TagGenerator.cachedTag[Int] | ||
TagGenerator.nonCachedTag[Int] | ||
|
||
// Benchmark non-cached variant | ||
val startNonCached = System.nanoTime() | ||
var sumNonCached = 0 | ||
(1 to iterations).foreach { _ => | ||
val tag = TagGenerator.nonCachedTag[Int] | ||
sumNonCached += tag.repr.length | ||
} | ||
val timeNonCached = System.nanoTime() - startNonCached | ||
|
||
// Benchmark cached variant | ||
val startCached = System.nanoTime() | ||
var sumCached = 0 | ||
(1 to iterations).foreach { _ => | ||
val tag = TagGenerator.cachedTag[Int] | ||
sumCached += tag.repr.length | ||
} | ||
val timeCached = System.nanoTime() - startCached | ||
|
||
println(s"Non-cached time: ${timeNonCached} ns") | ||
println(s"Cached time: ${timeCached} ns") | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
package benchmarks | ||
|
||
import izumi.reflect.TagGenerator | ||
|
||
object TagCachingBenchmark extends App { | ||
// ...existing code... | ||
val iterations = 100000 | ||
|
||
// Warm up | ||
TagGenerator.cachedTag[Int] | ||
TagGenerator.nonCachedTag[Int] | ||
|
||
// Benchmark non-cached variant | ||
val startNonCached = System.nanoTime() | ||
var sumNonCached = 0 | ||
(1 to iterations).foreach { _ => | ||
val tag = TagGenerator.nonCachedTag[Int] | ||
sumNonCached += tag.repr.length | ||
} | ||
val timeNonCached = System.nanoTime() - startNonCached | ||
|
||
// Benchmark cached variant | ||
val startCached = System.nanoTime() | ||
var sumCached = 0 | ||
(1 to iterations).foreach { _ => | ||
val tag = TagGenerator.cachedTag[Int] | ||
sumCached += tag.repr.length | ||
} | ||
val timeCached = System.nanoTime() - startCached | ||
|
||
println(s"Non-cached time: ${timeNonCached} ns") | ||
println(s"Cached time: ${timeCached} ns") | ||
|
||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
package izumi.reflect | ||
|
||
case class LightTypeTag(repr: String) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
package izumi.reflect | ||
|
||
import scala.quoted.* | ||
import izumi.reflect.macros.Scala3CachingMacros | ||
|
||
object TagGenerator { | ||
inline def cachedTag[T]: LightTypeTag = ${ Scala3CachingMacros.cachedTag[T] } | ||
inline def nonCachedTag[T]: LightTypeTag = ${ Scala3CachingMacros.computeLightTypeTag[T] } | ||
} |
34 changes: 34 additions & 0 deletions
34
src/main/scala/izumi/reflect/macros/Scala3CachingMacros.scala
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
package izumi.reflect.macros | ||
|
||
import scala.quoted.* | ||
import scala.collection.mutable | ||
import izumi.reflect.LightTypeTag | ||
|
||
object Scala3CachingMacros { | ||
// Changed cache to store computed string instead of Expr. | ||
private val tagCache: mutable.Map[Int, String] = mutable.Map.empty | ||
|
||
def cachedTag[T: Type](using Quotes): Expr[LightTypeTag] = { | ||
import quotes.reflect.* | ||
val tpeRepr = TypeRepr.of[T] | ||
val key = tpeRepr.hashCode | ||
tagCache.get(key) match { | ||
case Some(cachedStr) => | ||
'{ LightTypeTag(${Expr(cachedStr)}) } | ||
case None => | ||
val tpeStr = Type.show[T] | ||
var dummy = 0L | ||
for(i <- 1 to 10000) { dummy += i } | ||
tagCache(key) = tpeStr | ||
'{ LightTypeTag(${Expr(tpeStr)}) } | ||
} | ||
} | ||
|
||
def computeLightTypeTag[T: Type](using Quotes): Expr[LightTypeTag] = { | ||
import quotes.reflect.* | ||
val tpeStr = Type.show[T] | ||
var dummy = 0L | ||
for(i <- 1 to 10000) { dummy += i } | ||
'{ LightTypeTag(${Expr(tpeStr)}) } | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The loop is a dummy heavy computation meant to simulate an expensive operation during LightTypeTag creation. It's only for benchmarking purposes, so you can see the caching benefit by comparing the cached version to one that always runs this costly computation.