This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
WIP: Add FtpConnector #105
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # build.sbt # connectors/ftp-connector/src/main/scala/zio/connect/ftp/FtpConnector.scala # connectors/ftp-connector/src/main/scala/zio/connect/ftp/LiveFtpConnector.scala # connectors/ftp-connector/src/test/scala/zio/connect/ftp/FtpConnectorSpec.scala # connectors/ftp-connector/src/test/scala/zio/connect/ftp/LiveFtpConnectorSpec.scala
|
|
7 tasks
adrianfilip
reviewed
Nov 20, 2022
| FtpDependencies.testContainersScala, | ||
| `zio`, | ||
| `zio-streams`, | ||
| `zio-prelude`, |
There was a problem hiding this comment.
Can you move zio-prelude to FtpDependencies please. While it's an RC version I would like to avoid putting it in the core dependencies.
adrianfilip
reviewed
Nov 20, 2022
|
|
||
| def lsDescendant(path: => PathName): ZStream[Any, IOException, FtpResource] | ||
|
|
||
| def readFile(path: => PathName, chunkSize: Int = 2048)(implicit trace: Trace): ZStream[Any, IOException, Byte] |
There was a problem hiding this comment.
Suggested change
| def readFile(path: => PathName, chunkSize: Int = 2048)(implicit trace: Trace): ZStream[Any, IOException, Byte] | |
| def readFile(path: => PathName, chunkSize: => Int = 2048)(implicit trace: Trace): ZStream[Any, IOException, Byte] |
adrianfilip
reviewed
Nov 20, 2022
|
|
||
| import java.io.IOException | ||
|
|
||
| trait FtpConnector { |
There was a problem hiding this comment.
Should be ordered alphabetically
adrianfilip
reviewed
Nov 20, 2022
|
|
||
| import java.io.IOException | ||
|
|
||
| trait FtpConnectorSpec extends ZIOSpecDefault { |
There was a problem hiding this comment.
Suites should be ordered alphabetically in implementation and in the composed result
adrianfilip
reviewed
Nov 20, 2022
| zio.connect.ftp.ftpConnectorLiveLayer | ||
| ) | ||
|
|
||
| val ftpContainer: ZLayer[Scope, Throwable, FixedHostPortGenericContainer] = |
There was a problem hiding this comment.
Suggested change
| val ftpContainer: ZLayer[Scope, Throwable, FixedHostPortGenericContainer] = | |
| val ftpContainer: ZLayer[Any, Throwable, FixedHostPortGenericContainer] = |
adrianfilip
reviewed
Nov 20, 2022
| ) | ||
|
|
||
| val ftpContainer: ZLayer[Scope, Throwable, FixedHostPortGenericContainer] = | ||
| ZLayer.fromZIO( |
There was a problem hiding this comment.
Suggested change
| ZLayer.fromZIO( | |
| ZLayer.scoped( |
adrianfilip
reviewed
Nov 20, 2022
| })(f => ZIO.attempt(f.stop()).orDie) | ||
| ) | ||
|
|
||
| lazy val ftpLayer: ZLayer[Scope & FixedHostPortGenericContainer, ConnectionError, Ftp] = |
There was a problem hiding this comment.
Suggested change
| lazy val ftpLayer: ZLayer[Scope & FixedHostPortGenericContainer, ConnectionError, Ftp] = | |
| lazy val ftpLayer: ZLayer[FixedHostPortGenericContainer, ConnectionError, Ftp] = |
adrianfilip
reviewed
Nov 20, 2022
|
|
||
| lazy val ftpLayer: ZLayer[Scope & FixedHostPortGenericContainer, ConnectionError, Ftp] = | ||
| ZLayer | ||
| .fromZIO ( |
There was a problem hiding this comment.
Suggested change
| .fromZIO ( | |
| .scoped ( |
adrianfilip
reviewed
Nov 20, 2022
| val zio = "dev.zio" %% "zio" % zioVersion | ||
| val `zio-streams` = "dev.zio" %% "zio-streams" % zioVersion | ||
| val `zio-prelude` = "dev.zio" %% "zio-prelude" % zioPreludeVersion |
There was a problem hiding this comment.
Should be moved to the ftp dependencies. While it's RC I would like to keep it out of core dependencies.
adrianfilip
reviewed
Nov 20, 2022
| @@ -0,0 +1,16 @@ | |||
| import sbt._ | |||
|
|
|||
| object FtpDependencies { | |||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for #80