initial stab at new connector for kinesis streams #58 #102
Conversation
|
|
...ms-connector/src/main/scala/zio/connect/kinesisDataStreams/KinesisDataStreamsConnector.scala
Outdated
Show resolved
Hide resolved
...onnector/src/main/scala/zio/connect/kinesisDataStreams/LiveKinesisDataStreamsConnector.scala
Outdated
Show resolved
Hide resolved
...onnector/src/main/scala/zio/connect/kinesisDataStreams/TestKinesisDataStreamsConnector.scala
Outdated
Show resolved
Hide resolved
...ms-connector/src/main/scala/zio/connect/kinesisDataStreams/KinesisDataStreamsConnector.scala
Outdated
Show resolved
Hide resolved
|
Looks great 🙏 . Only a few minor observations. |
...s/kinesis-data-streams-connector/src/main/scala/zio/connect/kinesisDataStreams/package.scala
Outdated
Show resolved
Hide resolved
|
|
||
| trait KinesisDataStreamsConnector[T] { | ||
|
|
||
| def sinkChunked(implicit |
There was a problem hiding this comment.
👋 zio-kinesis author here.
I think the sinkChunked on the Producer could be changed to a non-chunked version, since ZStreams are chunked under the hood anyway. svroonland/zio-kinesis#791
I would recommend to change that here too, to not expose the Chunks in the interface.
There was a problem hiding this comment.
@svroonland I will merge this PR and apply your suggestions in a separate PR.
There was a problem hiding this comment.
@svroonland That PR change is not released yet. We will keep an eye on the releases and update it once 0.30.1 is out.
There was a problem hiding this comment.
Ah yes, I will try to make a release this week and will let you know here.
There was a problem hiding this comment.
@adrianfilip I just released 0.30.1, should be on Maven soon.
There was a problem hiding this comment.
@svroonland Fantastic. Will upgrade shortly.
This is the general structure of the Connector for Kinesis data streams, however there are some issues which ought to be resolved. Addresses issue #58