-
Notifications
You must be signed in to change notification settings - Fork 221
Add parameters of aws opensearch, support hnsw engine options, support multi-client load data #527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…dexConfig index_thread_qty_during_force_merge
…eters of hnsw engine and metric-type.
…eters of hnsw engine and metric-type.
…eters of hnsw engine and metric-type.
@norrishuang Thank you very much for your so detailed PR. I believe it will help the community test |
@norrishuang similar PR: https://github.com/zilliztech/VectorDBBench/pull/529/files with fixes and removal nmslib engine since it is deprecated. |
log.info( | ||
"Using innerproduct because faiss doesn't support cosine as metric type for Opensearch", | ||
) | ||
log.info("Using innerproduct because faiss doesn't support cosine as metric type for Opensearch") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cosine is supported with 2.19 and above version of Opensearch with faiss. I think this check can be removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @navneet1v , I removed it.
@@ -38,6 +38,9 @@ class AWSOpenSearchIndexConfig(BaseModel, DBCaseConfig): | |||
engine: AWSOS_Engine = AWSOS_Engine.faiss | |||
efConstruction: int = 256 | |||
efSearch: int = 256 | |||
ef_search: int = 200 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about removing one of efSearch
or ef_search
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed efSearch
in commit recover some code format
@norrishuang There is an issue with the format. pip install ruff --upgrade
pip install black --upgrade
make format
make lint |
fixed format issue. recover some code format |
@norrishuang some little conflicts with pr: #529 , could you please help resolve it~ |
The conflicts was resolved. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: alwayslove2013, norrishuang The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@norrishuang still seems to conflict with |
compare the code of conflicts, there are some code format issues, it's resolved. |
command example
and from UI
result log
result_20250521_ef-search-100_opensearch.json