Skip to content

Expand conditional types in hover popup #2349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

FnControlOption
Copy link
Contributor

@FnControlOption FnControlOption commented May 31, 2025

Screenshot 2025-05-30 at 10 10 45 PM Screenshot 2025-06-15 at 8 51 17 AM Screenshot 2025-06-15 at 8 52 16 AM Screenshot 2025-06-15 at 8 51 30 AM Screenshot 2025-06-15 at 8 59 54 AM

@FnControlOption FnControlOption force-pushed the hover branch 4 times, most recently from c4afad2 to 27b74cb Compare June 5, 2025 21:42
Copy link
Member

@Techatrix Techatrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

const foo = if (true) 1 else true;

const bar = if (true)
    .{ foo, foo, foo, foo, foo, foo, foo, foo, foo, foo, foo, foo, foo, foo, foo, foo, foo, foo, foo, foo, foo, foo, foo }
else
    .{ foo, foo, foo, foo, foo, foo, foo, foo, foo, foo, foo, foo, foo, foo, foo, foo, foo, foo, foo, foo, foo, foo, foo };

Hovering over bar will cause ZLS to consume huge amounts of memory. Not sure when it stops but it's at least 10GB.

@FnControlOption FnControlOption marked this pull request as draft June 11, 2025 15:01
@FnControlOption FnControlOption force-pushed the hover branch 3 times, most recently from a438dfc to d8be34f Compare June 18, 2025 13:13
@FnControlOption FnControlOption marked this pull request as ready for review June 18, 2025 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants