Translator: use NIX_CFLAGS_COMPILE to find system headers #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This mirrors some functionality in upstream zig itself, where it will use these env vars to discover system headers for `@cImport` I'm having it run in the configure phase, which feels most appropriate to myself and one other person in [this ziggit thread](https://ziggit.dev/t/aro-translate-c-nixos-integration/11576/2).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mirrors some functionality in upstream zig itself, where it will use these env vars to discover system headers for
@cImportI'm having it run in the configure phase, which feels most appropriate to myself and one other person in this ziggit thread.
I have not added automated tests to this: I am willing to, but I'd appreciate advice on how best to go about that, if it's desired.
This, along with #40, builds on a project I'm working on, using zig
0.15.0-dev.1564+2761cc8be. I have tested it within a nix shell. I have not tested inside of a "true" nix build, but I don't anticipate that working much differently. Famous last words?